-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/conjugation box #984
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code all looks great. Do you think it's worth adding case handling for QControlBox
with this new conjugation box to only control on the action in this PR? It's the obvious functionality that this gives benefit to.
Similarly, PauliExpBox
could be considered a child of this new box type, do you think its easy to update PauliExpBox
to have a similar structure and benefit from quantum control off only the action (i.e. rotation)?
Yeah, I plan to do these things in separate PR(s). The |
Adds ConjugationBox to capture any compute-action-uncompute pattern.
By default, uncompute will be derived from compute, but the user has the ability to provide a custom operation.
The current pytket interface has some limitation therefore the three operations need to have the same number of qubits.